Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return an astropy Table from get_detector_sun_angles_for_date #70

Open
dstansby opened this issue Sep 9, 2022 · 0 comments
Open

Return an astropy Table from get_detector_sun_angles_for_date #70

dstansby opened this issue Sep 9, 2022 · 0 comments

Comments

@dstansby
Copy link
Member

dstansby commented Sep 9, 2022

Describe the feature

Currently get_detector_sun_angles_for_date returns a dict that looks like:

{'n0': <Quantity 68.69273342 deg>, 'n1': <Quantity 53.92502079 deg>, 'n2': <Quantity 58.65814136 deg>, 'n3': <Quantity 54.1029331 deg>, 'n4': <Quantity 57.30596383 deg>, 'n5': <Quantity 7.86667182 deg>, 'n6': <Quantity 97.18921967 deg>, 'n7': <Quantity 114.91600048 deg>, 'n8': <Quantity 123.17782321 deg>, 'n9': <Quantity 114.29061848 deg>, 'n10': <Quantity 123.3723935 deg>, 'n11': <Quantity 172.06369333 deg>, 'time': <Time object: scale='utc' format='isot' value=2020-01-01T00:00:02.600>}

I think it would make sense to return a (single row) astropy table here. That way the object would have a nice str, and could be eaily concatenated with other values returned from this function.

Proposed solution

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant