Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETHEREUM-CONTRACTS] Completness of the upgrade/downgrade flows of Super Tokens #1317

Open
hellwolf opened this issue Mar 17, 2023 · 0 comments
Labels
Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity Type: Enhancement New feature or request

Comments

@hellwolf
Copy link
Contributor

hellwolf commented Mar 17, 2023

(... per community input ...)

Notes

Extend SuperToken upgrade/downgrade with more overloaded versions of them.

  • upgrade(amount)
  • upgradeTo(to, amount) # *
  • upgradeTo(to, amount, userData)
  • upgradeFrom(from, to, amount) # *
  • upgradeFrom(from, to, amount, userData) # *
  • downgrade(amount)
  • downgradeTo(to, amount)
  • downgradeTo(to, amount, userData) #*
  • downgradeFrom(from, to, amount) # *
  • downgradeFrom(from, to, amount, userData) # *
  • expose the underlyingAmount <-> supertoken amount arithematic to the user for easier integration. Using the example from TOREX BLM for reference.

We do not add these, in favor of the macro versions:

  • downgradeAllTo(to)
  • downgradeAllFrom(from, to)
@hellwolf hellwolf added this to the [email protected] - Giga milestone Mar 17, 2023
@hellwolf hellwolf added Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps Type: Enhancement New feature or request labels Aug 23, 2023
@hellwolf hellwolf added the Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity label Jan 18, 2024
@hellwolf hellwolf removed the Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps label Mar 11, 2024
@hellwolf hellwolf changed the title [ETHEREUM-CONTRACTS] Extend SuperToken upgrade/downgrade with more overloaded versions of them [ETHEREUM-CONTRACTS] Completness of the upgrade/downgrade flow of Super Tokens Mar 13, 2024
@hellwolf hellwolf changed the title [ETHEREUM-CONTRACTS] Completness of the upgrade/downgrade flow of Super Tokens [ETHEREUM-CONTRACTS] Completness of the upgrade/downgrade flows of Super Tokens Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant