Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PROTOCOL-OPS] add test for Safe gov method #1655

Open
d10r opened this issue Sep 3, 2023 · 0 comments
Open

[PROTOCOL-OPS] add test for Safe gov method #1655

d10r opened this issue Sep 3, 2023 · 0 comments
Assignees
@d10r
Labels
Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity Tag: TechDebt Technical debt that needs to be addressed Type: Testing Testing cases or harness improvements

Comments

@d10r
Copy link
Collaborator

d10r commented Sep 3, 2023

We now have support for Safe gov & resolver owners in ops-scripts, but no test coverage for it.
Note that this are off-chain operations, talking to Safe APIs using their SDK.
Before starting, check if there's an idiomatic way to achieve this, e.g.a Safe provided sandbox environment.

AC:

  • Testcase which fails if the code fails to propose a tx to be signed.
@d10r d10r added the Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps label Sep 3, 2023
@d10r d10r self-assigned this Sep 3, 2023
@hellwolf hellwolf added Tag: TechDebt Technical debt that needs to be addressed Type: Testing Testing cases or harness improvements labels Oct 9, 2023
@hellwolf hellwolf added the Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity label Jan 18, 2024
@hellwolf hellwolf changed the title [ETHEREUM-CONTRACTS] add test for Safe gov method [PROTOCOL-OPS] add test for Safe gov method Jan 23, 2024
@hellwolf hellwolf removed the Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@d10r d10r

Labels
Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity Tag: TechDebt Technical debt that needs to be addressed Type: Testing Testing cases or harness improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hellwolf @d10r