Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to QT5 #7

Open
miramikes opened this issue Oct 11, 2017 · 2 comments
Open

Update to QT5 #7

miramikes opened this issue Oct 11, 2017 · 2 comments

Comments

@miramikes
Copy link

Hi,

there is ongoing process in debian - removing QT4 from debian archive
Is there any chance get Midisnoop build against QT5?

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=875047

best regards

mira

@lumag
Copy link

lumag commented Sep 11, 2019

Midisnoop builds against Qt5. However @surfacepatterns what about marking current tree as a release?

@edogawa23
Copy link

edogawa23 commented Nov 10, 2019

openSUSE also phased out Qt4 recently. For me midisnoop didn't build against Qt5, but it needed only a few adjustments, adjusting some #include and the common "QT += core widgets" line in midisnoop.pro.

But I also had to deal with some API change in RtMidi (RtError->RtMidiError) and omit an obsolete check (for WINDOWS_KS).

Attached is a zipped git diff with all my changes that made it compile, sorry for mixing several unrelated things in there. Qmake executable name probably should not be hardcoded in midisnoop.pro, rather be found by some routine as it differs across distributions, this is just my quick effort to make it compile. I really should rather create pull requests but I'm still a bit unfamiliar with github and too much in a hurry right now, so bear with me please...

midisnoop-qt5port_and_bitrot.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants