-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse 86
tag (information_to_account_owner) as a struct
#59
Comments
I looked at the Python project referenced in the Readme and it looks like they are decoding the information. Their parsing logic seems to be in this I might find some time to implement this and make a PR. But I'm wondering what would be the best place to add it. Should I add it to the pest grammar file? This would probably necessitate to add some extra fields to the parsing results, as the
|
Thanks for you interest to work on this! I think it should probably be added to the pest file as you suggested. From the Python code, it appears like it should be somewhat easy to parse. Would this live entirely in |
Alright! I'll try to look into this in the following days. The project I need this for is a low effort high priority one for me, so it might take me some time to get back to it. Without having given your code a second look I assume it could be kept inside |
Sounds good. I think you'll find the code is fairly easy to get into as it's kept simple and compartmentalized. |
information_to_account_owner
like ?20
86
tag (information_to_account_owner) as a struct
@erictapen you still on the case? |
I still want to implement it, but other stuff has more priority in the next ~2 months I'm afraid. |
Alright sure, the issue is going nowhere. :) |
Would you like to try to pick this up? |
Sorry, other things in my head currently. |
Ah, well then. I'll just leave this open for later then. |
Thanks for this great library.
I'm struggling to understand the meaning of these character encodings for the
information_to_account_owner
field, like they can be seen here: https://github.com/svenstaro/mt940-rs/blob/master/tests/data/mt940/full/betterplace/with_binary_character.json#L26They don't seem to be modified by the parsing code and I wonder, where the decoding logic for that should be located. Is that some part of the MT940 standard that's not implemented yet? Or is the user expected to decode this? And if yes, does any resource come to your mind explaining the encoding?
Because I suppose the two digit codes?20
represent ASCII characters, but I can't make any sense of strings like the051?00
in the beginning.Edit: I now got some idea of the
?
encoding. It doesn't encode special characters but separates fields identified by the two digits after the?
. What I don't get yet is what the three digits at the beginning and end mean.The text was updated successfully, but these errors were encountered: