Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

embedded http client user-agent string should include library version #108

Open
tomerd opened this issue Jun 2, 2020 · 2 comments
Open

embedded http client user-agent string should include library version #108

tomerd opened this issue Jun 2, 2020 · 2 comments
Labels
kind/enhancement Improvements to existing feature.

Comments

@tomerd
Copy link
Contributor

tomerd commented Jun 2, 2020

#98 (comment)
@tomerd tomerd added kind/enhancement Improvements to existing feature. good first issue Good for newcomers labels Jun 2, 2020
@tomerd tomerd mentioned this issue Jun 2, 2020
Merged
@weissi
Copy link
Contributor

weissi commented Jun 2, 2020

this is my SwiftPM feature request to allow this: https://bugs.swift.org/browse/SR-12926

@tomerd tomerd removed the good first issue Good for newcomers label Jun 2, 2020
@weissi weissi mentioned this issue May 4, 2022
Open
@sebsto
Copy link
Contributor

sebsto commented May 29, 2024

Not fixed as of today
https://github.com/swift-server/swift-aws-lambda-runtime/blob/main/Sources/AWSLambdaRuntimeCore/LambdaRuntimeClient.swift#L137

@weissi any idea if SR-12926 will be adopted ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Improvements to existing feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tomerd @sebsto @weissi