Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option for specifying the request timeout per single call #367

Open
akudiyar opened this issue Mar 16, 2023 · 0 comments
Open

Add an option for specifying the request timeout per single call #367

akudiyar opened this issue Mar 16, 2023 · 0 comments
Labels
feature A new functionality good first issue Good for newcomers

Comments

@akudiyar
Copy link
Collaborator

Sometimes we do not want to change the default timeout for all the application code, but just add more time for a particular call (e.g. a large select). In that case, it may be useful to pass a special requestTimeout parameter to the request. We already have the "options" parameter for each call, which makes it possible to pass the new parameter there.

Proposal:

  • new field requestTimeout in options parameter for each call type (we may add it directly here or make a new base derived class)
  • pass that parameter in the base client implementation first to sendRequest, then to submitRequest
  • if the options or requestTimeout there are not specified, use the existing behavior - the default request timeout from the global config
@akudiyar akudiyar added good first issue Good for newcomers feature A new functionality labels Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new functionality good first issue Good for newcomers
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants