Skip to content
This repository has been archived by the owner on Aug 19, 2022. It is now read-only.

Use a Spotify SDK rather than our messy calls #77

Open
paced opened this issue Oct 5, 2021 · 5 comments
Open

Use a Spotify SDK rather than our messy calls #77

paced opened this issue Oct 5, 2021 · 5 comments
Assignees
Labels
refactor This ticket refactors existing code
Milestone

Comments

@paced
Copy link
Member

paced commented Oct 5, 2021

It is better to use somebody's tested work rather than writing our own code to interact with the Spotify SDK. It would clean up a lot of the code for contributors.

This should be done before the TSX refactor.

@paced paced added the task Something to do that isn't a feature label Oct 5, 2021
@paced paced added this to the v0.11.0 milestone Oct 5, 2021
@alexresiga
Copy link

Hi! I have previously used this https://github.com/jmperez/spotify-web-api-js which works really great. I have previously worked with spotify web api for a few projects and I could give a helping hand with this one

@paced
Copy link
Member Author

paced commented Oct 10, 2021

Apologies for the late reply, wasn't really available this weekend @alexresiga.

Sure, that sounds good. That particular SDK works perfectly for us, feel free to go ahead! Feel free to keep me in the loop or ask questions about the existing codebase if needed. Thanks!

@paced
Copy link
Member Author

paced commented Oct 21, 2021

Hi @alexresiga, @teaminkling/engineering's sprint is mostly focused on other internal projects but I'll have some time to move back to Now Playing soon. I'll likely make sweeping changes to much of the codebase. Would you like some more time to work on this before I make those changes?

@alexresiga
Copy link

Hi @paced, unfortunately I got caught up with a lot of stuff at my job and I didn't even manage to get started. You can go on with your changes and I'll see when I will have the time to work on it.

@paced
Copy link
Member Author

paced commented Oct 21, 2021

Cheers @alexresiga!

Sure, I estimate I'll be able to look at this again on Sunday or some time thereafter.

@paced paced modified the milestones: v0.11.0, v0.12.0, v0.13.0 Oct 28, 2021
@paced paced added enhancement New feature or request and removed task Something to do that isn't a feature labels Jan 1, 2022
@paced paced modified the milestones: v0.13.0, v0.11.0 Jun 18, 2022
@paced paced self-assigned this Jun 19, 2022
@paced paced added refactor This ticket refactors existing code and removed enhancement New feature or request labels Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
refactor This ticket refactors existing code
Projects
No open projects
Status: No status
Development

No branches or pull requests

2 participants