Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use module acm-certificate to create the cert #14

Open
ddriddle opened this issue Nov 19, 2019 · 0 comments
Open

Refactor to use module acm-certificate to create the cert #14

ddriddle opened this issue Nov 19, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@ddriddle
Copy link
Contributor

ddriddle commented Nov 19, 2019

To avoid code duplication it would be best to use module acm-certificate as a submodule to create the certificate. One challenge to consider is that this module performs a data lookup on the zone. The same lookup is performed in the acm-certificate module. To avoid unnecessary lookups we need the ability to pass the zone_id instead of the domain name to the submodule (See acm-certificate#10).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants