-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.8.0 breaks exiting scope handling #1052
Comments
Discussion to be continued in #1030 please. |
Can you try if #1053 fixes your issue? |
@barryvdh that fixes the issue |
I have been going crazy chasing this issue with the Google Provider where the scopes requested outside of the default were being lost on refresh token actions. I have downgraded back to 2.7.0 temporarily to fix this. It would be good to pin this issue because the Google Provider gets broken pretty bad by this currently. |
Last week's release introduced the following in the
getAccessToken()
function:https://github.com/thephpleague/oauth2-client/pull/1030/files#diff-e8490e4bb8acb102745699d2bd7aa0a298d836c92d00d2ed57dd4c7ad8b24282
This broke my existing integration because previously added scopes were lost and I got an API error:
ACCESS_TOKEN_SCOPE_INSUFFICIENT
.To "fix" the issue, I had to add the scopes like this while refreshing the token:
All the default (
'openid', 'email', 'profile'
) scopes, plus the one I already added while callinggetAuthorizationUrl()
. So to me, 2.8.0 is a breaking change that should have been mentioned.The text was updated successfully, but these errors were encountered: