Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'test_sync_modif' fails randomly #34

Open
sunhaitao opened this issue Oct 21, 2020 · 4 comments
Open

'test_sync_modif' fails randomly #34

sunhaitao opened this issue Oct 21, 2020 · 4 comments

Comments

@sunhaitao
Copy link
Contributor

While running on a SSD, 'test_sync_modif' has about a half chance of failing.
@sunhaitao sunhaitao mentioned this issue Oct 21, 2020
Merged
@tkhyn
Copy link
Owner

tkhyn commented Oct 30, 2020

Hi,

This is a bit strange, I've never used anything else than SSDs to run the dirsync tests on, and never encountered a failure. Do you have a particularly fast SSD?

Anyway, it should not affect the validity of the test to add a timeout, so I'll merge your PR. Thanks!

@tkhyn
Copy link
Owner

tkhyn commented Oct 30, 2020

#36, which addresses this, has been merged, but keeping open for discussions on the root cause

@sunhaitao
Copy link
Contributor Author

Just a normal SSD on Fedora 32. Let me collect more details on this, and report them later.

@sunhaitao
Copy link
Contributor Author

sunhaitao commented Nov 1, 2020 •
edited
Loading

I tested this on a 2018 notebook running Ubuntu 20.04 with both an SSD and an HDD. Those random failures DO only appear while running on the SSD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sunhaitao @tkhyn