Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Python 3.7 or higher #308

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Igor-manukyan
Copy link

@Igor-manukyan Igor-manukyan commented May 13, 2021

I want to close #303 issues


Please make sure all below checkboxes in the Mandatory section have been checked before submitting your PR (also don't forget to pay attention to the Depending on Circumstances section)

Mandatory

  • The commit message is an imperative and starts with a capital letter (for example, Add something, Remove something, Fix something, etc.).
  • I made sure I hadn't put a period at the end of the the commit message(s).

Depending on Circumstances

Some of the items in the section become mandatory if you are a first-time contributor and/or your changes are relevant to the items.

  • Adding a new parameter I didn't forget to reflect it in README.md.
  • Adding a new parameter or modifying an existing one I didn't break the alphabetical order.
  • Adding a new utility written in Python I didn't forget to reflect it in pieman/README.md.
  • Adding a new utility written in Python I didn't forget to increase the version number of the pieman package in pieman/setup.py, pieman/pieman/__init__.py and essentials.sh.
  • (for first-time contributors) One of the commits in the pull request adds me to the Acknowledgements section in AUTHORS.md.

@Igor-manukyan Igor-manukyan changed the title Changed the required python version from 3.5 and higher to 3.7 and hi… Change the required python version from 3.5 and higher to 3.7 and hi… May 13, 2021
@Igor-manukyan Igor-manukyan force-pushed the essentials.sh-edited branch from ee908f8 to e21ef1f Compare May 13, 2021 13:19
@Igor-manukyan Igor-manukyan changed the title Change the required python version from 3.5 and higher to 3.7 and hi… Require Python 3.7 or higher May 13, 2021
@Igor-manukyan Igor-manukyan force-pushed the essentials.sh-edited branch from cebfa7e to c1dd806 Compare May 13, 2021 13:57
@Themanwhosmellslikesugar
Copy link
Member

Change AUTHORS.md -> Add Igor Manukyan to AUTHORS.md

@Igor-manukyan Igor-manukyan force-pushed the essentials.sh-edited branch from c1dd806 to 504086a Compare May 13, 2021 14:04
@Igor-manukyan Igor-manukyan force-pushed the essentials.sh-edited branch from cf40eed to 44d92c5 Compare May 14, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require Python 3.7 or higher
2 participants