Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxResults not applying to listing playlists #65

Open
SlidingHorn opened this issue Mar 31, 2022 · 0 comments
Open

maxResults not applying to listing playlists #65

SlidingHorn opened this issue Mar 31, 2022 · 0 comments

Comments

@SlidingHorn
Copy link

SlidingHorn commented Mar 31, 2022

This may or may not be related to #57 - Apologies if so - but the point of my post is more about a UI/UX consistency issue than it is about whether or not maxResults applies universally, etc.

Basically, in my pipe-viewer.conf, max results is set to 20, which I believe is the default. It's pretty much perfect for my use case - which is most often having pipe-viewer in a terminal that's one of two windows stacked vertically on one side of my screen (e.g. in the secondary stack of dwm). However, when looking at a channel's playlists (:pi), for example, that limit is ignored, and there are 30 results displayed. In my case, this means that results 1-9 are cut off.

For someone who sets up their environment in order to be able to keep their hands on their keyboard as much as possible, the resulting need to scroll back in the list to view those first 9 listings is a pain.

Whether or not you choose to have the maxResults setting in one's config file affect all results is one thing (which, for the record, I think it probably should - the caveat being if someone sets it to something ridiculous like 10000 results), but I think it would be good practice to produce the same number of results across different types of searches (videos/channels/playlists) from a UI/UX standpoint.

As always, thanks for your time and all the effort you put into this project.


Edit: Didn't finish a sentence...got distracted and moved on to the next when I came back, lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant