From 6afc165a084bb66543ceae4fd8c87a52ed21601f Mon Sep 17 00:00:00 2001 From: Josh Reini Date: Tue, 29 Oct 2024 15:35:37 -0400 Subject: [PATCH] fix assertion to nan (#1605) --- tests/unit/test_feedback.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tests/unit/test_feedback.py b/tests/unit/test_feedback.py index 9bc4bfb42..9eea642ec 100644 --- a/tests/unit/test_feedback.py +++ b/tests/unit/test_feedback.py @@ -64,10 +64,7 @@ def test_skipeval_all(self) -> None: self.assertIsInstance(res.result, float) - self.assertIs( - res.result, np.nan - ) # NOTE: cannot use assertEqual for nans. - # Result should be nan if all evals were skipped. + self.assertTrue(np.isnan(res.result)) self.assertEqual(res.status, feedback_schema.FeedbackResultStatus.DONE) # But status should be DONE (as opposed to SKIPPED or ERROR)