Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] External links not opening #863

Open
1 of 2 tasks
ds201ues opened this issue Dec 9, 2024 · 7 comments
Open
1 of 2 tasks

[Bug] External links not opening #863

ds201ues opened this issue Dec 9, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@ds201ues
Copy link

ds201ues commented Dec 9, 2024

Search before asking

  • 我在 issues 列表中搜索,没有找到类似的内容。
    I searched in the issues and found nothing similar.

Pake version

2.6.1

System version

MacOS 15.1.1

Node.js version

23.3.0

Minimal reproduce step

pake https://chat.google.com

In compiled package, external links are not opening on clicking.

What did you expect to see?

External links should open on click

What did you see instead?

Nothing happens

Anything else?

Tried clicking with holding Cmd as well

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@ds201ues ds201ues added the bug Something isn't working label Dec 9, 2024
@Karreg
Copy link

Karreg commented Dec 12, 2024

I have the same issue. Thanks for opening the thread.

MacOS 15.1.1
pake 2.6.1
Node 23.3.0

@ds201ues
Copy link
Author

@tw93 Any suggestion to resolve this?

@ltaoo
Copy link

ltaoo commented Dec 18, 2024

The actual address you opened is not chat.google.com, but rather workspace.google.com/products/chat. You need to use the address https://workspace.google.com/products/chat.

@ds201ues
Copy link
Author

Still doesn't work. Tried the above address as well. I don't think that's the issue.

@ltaoo
Copy link

ltaoo commented Dec 18, 2024

Could you provide a screenshot to show which external links do not open when clicked?

image
When I click the links here, they open in the default browser.

@ds201ues
Copy link
Author

None of the links are opening. Attaching screenshot below

image image

@ltaoo
Copy link

ltaoo commented Dec 18, 2024

I understand your error. This is because the chat window is an iframe within the page.

image
We can open the links here, but we are unable to open the links in the chat window.

This is quite a challenging question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants