Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multiple strings to represent the name #873

Open
2 tasks done
g1eny0ung opened this issue Dec 23, 2024 · 2 comments · May be fixed by #876
Open
2 tasks done

Use multiple strings to represent the name #873

g1eny0ung opened this issue Dec 23, 2024 · 2 comments · May be fixed by #876
Labels
enhancement New feature or request

Comments

@g1eny0ung
Copy link

g1eny0ung commented Dec 23, 2024

Search before asking

  • 我在 issues 列表中搜索,没有找到类似的内容。
    I searched in the issues and found nothing similar.

Motivation

I use a Mac for my daily work. Most apps I used have spaces between their names (aka a normal, no-symbol name). Can we specify the name with spaces before building?

For example, I want to wrap Google Translate with Pake, and I can specify its name as "Google Translate" rather than "GoogleTranslate" or "Google-Translate".

Solution

I took an investigation and found https://github.com/tj/commander.js#variadic-option. Using the variadic option can take multiple strings into an array, then we can turn this array into a string with spaces with the .join() method.

Alternatives

No response

Anything else?

But I'm not sure if it can be set the application name to a normal name on Windows or Linux? I haven't used these platforms for a long time.

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@g1eny0ung g1eny0ung added the enhancement New feature or request label Dec 23, 2024
@g1eny0ung g1eny0ung changed the title Whether to use multiple strings to represent the name Use multiple strings to represent the name Dec 23, 2024
@tw93
Copy link
Owner

tw93 commented Dec 23, 2024

Great, your idea is quite good. Feel free to submit a PR, and I'll merge the code.

@g1eny0ung g1eny0ung linked a pull request Dec 24, 2024 that will close this issue
@g1eny0ung
Copy link
Author

Great, your idea is quite good. Feel free to submit a PR, and I'll merge the code.

I have completed the modification. You can check the PR for a detailed description. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants