Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twitter-cldr automatically sentence-casing elements (TimespanFormatter, patterns) #81

Open
pchew-change opened this issue Aug 15, 2016 · 1 comment

Comments

@pchew-change
Copy link

The values for TimespanFormatter:patterns are all sentence cases, with the letter of the first word capitalized, e.g.

The values in the CLDR code charts are all lower cased, e.g.:

This causes problems when the value to be inserted is not in sentence-initial position, viz. in the middle of the sentence, e.g.:

Please advise.

@camertron
Copy link
Collaborator

Hey @pchew-change, unfortunately the fields/units data built into this gem are from CLDR v23, not v29 as you linked. In v23, time spans were uppercased. The ruby version of twitter_cldr also suffers from this issue. As I mentioned in #80, I'm working on supporting the new units data introduced in CLDR v24, which should let us move to v29 without too many problems. Then I should be able to focus on improving the Javascript story.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants