Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsupported migration paths block Umbraco from loading without logging #17672

Open
timgaunt opened this issue Nov 28, 2024 · 1 comment · May be fixed by #17673
Open

Unsupported migration paths block Umbraco from loading without logging #17672

timgaunt opened this issue Nov 28, 2024 · 1 comment · May be fixed by #17673
Labels
community/pr type/bug

Comments

@timgaunt
Copy link

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.5.1

Bug summary

When running a site that has an invalid path in the umbracoKeyValue table in product mode, the site loads with the Umbraco failed screen but there's nothing in the logs

Specifics

When there is an invalid migration path and the developer is running locally there is a nice error message explaining the issue:

 
BootFailedException: Boot failed: Umbraco cannot run. See Umbraco's log file for more details. -> Umbraco.Cms.Core.Exceptions.BootFailedException: The migration plan does not support migrating from state "006909ca-4940-475b-abe5-63a25f2d5aa5". -> System.InvalidOperationException: The migration plan does not support migrating from state "006909ca-4940-475b-abe5-63a25f2d5aa5". at Umbraco.Cms.Infrastructure.Migrations.MigrationPlan.ThrowOnUnknownInitialState(String state) at Umbraco.Cms.Infrastructure.Migrations.MigrationPlanExecutor.RunMigrationPlan(MigrationPlan plan, String fromState) at Umbraco.Cms.Infrastructure.Migrations.MigrationPlanExecutor.ExecutePlan(MigrationPlan plan, String fromState) at 
...

However when this is run on the server, there is no logging at all to explain the issue and the Umbraco "Boot Failed" screen is all you get (the same one when the database can't be contacted).

image

The issue is there is no logging to explain that there is an issue so to track it down you have to run the site in Debug mode.

It would be helpful if there was extra logging before throwing an exceptopn to make it easier to track down. I think something here would make sense: https://github.com/umbraco/Umbraco-CMS/blob/v9/contrib/src/Umbraco.Infrastructure/Migrations/MigrationPlanExecutor.cs#L53

Steps to reproduce

Create a migration that doesn't have a valid path

Expected result / actual result

Some form of log message to indicate what went wrong.
@github-actions GitHub Actions
Copy link

Hi there @timgaunt!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@timgaunt timgaunt linked a pull request Nov 28, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community/pr type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improved logging around failed migrations timgaunt/Umbraco-CMS
2 participants
@timgaunt @elit0451