Empty groups appear in block grid editor "Add content" UI

[stephen-sherman]

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

15.1.0

Bug summary

Empty groups appear in the block grid editor "Add content" UI:

Specifics

No response

Steps to reproduce

1. Install a new Umbraco 15.1.0 solution
2. Configure a block grid data type to have two groups, one containing blocks allowed in the root of the editor, and one containing blocks that are only allowed in areas
3. Create a node using the above data type and add some blocks to it

Expected result / actual result

Expected result

• Only groups with relevant blocks are visible to the user.

Actual result

• Empty groups are visible to the user.

[github-actions]

Hi there @stephen-sherman!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[NguyenThuyLan]

Hi @stephen-sherman , I don't see this issue as a bug.
When Allow in root is not enabled, you can only see that Block within Block Areas, see this Block Permissions

I can give you an example here, I have two elements in a Block Grid, StringElement is enabled Allow in root and TextAreaElement is enabled Allow in areas, so for the first time I can only add StringElement, after that, I can add TextAreaElement into StringElement like this

[stephen-sherman]

Hi @NguyenThuyLan,

Sorry, your response doesn't address the issue I'm raising.

Consider the following configuration:

• SectionBlockA, SectionBlockB
  • Group: "Section Blocks"
  • Allow in root: true
  • Allow in areas: false
• ComponentBlockA, ComponentBlockB
  • Group: "Component Blocks"
  • Allow in root: false
  • Allow in areas: true

Now attempt to add a block to the root.

In Umbraco 13, the user interface shows only the group of blocks that can be added.

In Umbraco 15, the user interface shows empty groups as well.

I think that the Umbraco 13 approach is better.

In the above example, the heading "Component Blocks" serves no purpose - it just takes up space in the interface and confuses editors. The problem is exacerbated when there are many groups.

I would suggest that when a group of blocks is empty, the heading of that group should not be rendered.

[NguyenThuyLan]

Oh, sorry for misunderstanding you, your suggestion is quite reasonable. Thank you @stephen-sherman