From 5b01524d38811a3430f532e38f13cc442010666c Mon Sep 17 00:00:00 2001 From: blm Date: Thu, 17 Nov 2022 14:13:45 -0500 Subject: [PATCH] update build notes --- docs/development/Electronite/MacBuildNotes.md | 3 ++- docs/development/Electronite/WindowsBuildNotes.md | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/docs/development/Electronite/MacBuildNotes.md b/docs/development/Electronite/MacBuildNotes.md index 34b5406f54745..05ea599152719 100644 --- a/docs/development/Electronite/MacBuildNotes.md +++ b/docs/development/Electronite/MacBuildNotes.md @@ -17,7 +17,8 @@ nvm use v16 node --version ``` - installed homebrew: `/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install.sh)"` -- Installed Python 3.9 (Python 3.10 has breaking changes that broke the compile) `brew install python@3.9` +- Installed Python 3.9 (Python 3.10 has breaking changes that broke the compile) `brew install python@3.9`. Check by `python3 --version` +- make sure there is a Python 2 installed by `python --version` (should report 2.x.x) - configured Python: ``` pip3 install --user --upgrade pip diff --git a/docs/development/Electronite/WindowsBuildNotes.md b/docs/development/Electronite/WindowsBuildNotes.md index 689ff36a724f8..d7837c6c4727f 100644 --- a/docs/development/Electronite/WindowsBuildNotes.md +++ b/docs/development/Electronite/WindowsBuildNotes.md @@ -10,8 +10,9 @@ - Under Virus & threat protection settings, select Manage settings, and then under Exclusions, select Add or remove exclusions. - Add folder `.\Build-Electron` (which is the default build folder used below, or the build folder you actually use). - Add to git support for long file names: `git config --system core.longpaths true` -- Installed VS 2019 Community edition and Windows SDK 10.0.19041.0. -- Installed Python 3.9.11 (Python 3.10 has breaking changes that broke compile) from `https://www.python.org/downloads/windows/`. Had problem at run time that `python3` could not be found. So I found the path to the python3 installation. When I looked in there it only had a `python.exe`, so I just copied it and renamed the copy to be `python3.exe`. +- Installed VS 2019 Community edition and Windows SDKs 10.0.19041.0 and 10.0.20348.0. Some Electron build will pick the one it needs. +- Installed Python 3.9.11 (Python 3.10 has breaking changes that broke compile) from `https://www.python.org/downloads/windows/`. Check by `python3 --version`. +- make sure there is a Python 2 installed by `python --version` (should report 2.x.x) - configured Python: ``` python3 -m pip install --upgrade pip setuptools wheel