Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NuGet package shouldn't have a public class Class1 #24

Closed
Youssef1313 opened this issue Jan 19, 2023 · 4 comments · May be fixed by #26
Closed

NuGet package shouldn't have a public class Class1 #24

Youssef1313 opened this issue Jan 19, 2023 · 4 comments · May be fixed by #26
Labels
kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification.

Comments

@Youssef1313
Copy link
Member

Looking into the dll in the NuGet package, it has a public class Class1 (the only API in the package).

Ideally, we shouldn't have to have a dll at all. @jeromelaban I expect this was done to workaround some error, what was the error?

At the very least, the dll shouldn't have any public APIs.
@Youssef1313 Youssef1313 added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification. labels Jan 19, 2023
@jeromelaban
Copy link
Member

It's not exactly a workaround, but it's more related to the way uno deals with content files and how the lookup for transitive assets work in Uno. It's done through lookup from runtime items, and those are not included automatically using the default nuget behavior.

Still, having class1 is not particularly useful, I agree :) I'll remove it. Thanks!

@Youssef1313
Copy link
Member Author

@jeromelaban I'm taking a lot.

@Youssef1313
Copy link
Member Author

Oh I see you did that in #25.

Though I worked on an approach to avoid having the dll completely, and also moved to csproj instead of nuspec (that's more modern and manageable approach).

@Youssef1313 Youssef1313 mentioned this issue Jan 19, 2023
Open
7 tasks
@Youssef1313
Copy link
Member Author

Closing as fixed by #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Refactor package packing Youssef1313/uno.fonts
2 participants
@jeromelaban @Youssef1313