password_plaintext considered harmful

[annabunches]

The members table has this field. It probably shouldn't. My recommendations:

1. make sure it isn't used anywhere
2. drop the field from the table
3. update the schema
4. profit

[annabunches]

Findings so far (a bit rambly, more succinct updates when I know more):

• Only the 'admin' routes should be able to write this field. The 'standard', unprivileged routes for creating and updating a member go through the restricted_save method, which doesn't allow the field to be written, see:
  https://github.com/usgo/membership/blob/master/mm_app/models/member.php#L76
  https://github.com/usgo/membership/blob/master/mm_app/models/member.php#L696
  https://github.com/usgo/membership/blob/8af41cbd437b0558ad58b2f2b873cd780432ee49/mm_app/lib/render_forms.php#L894
• In fact, the only time Member::save is called directly appears to be in the mass edit code:
  https://github.com/usgo/membership/blob/cd4796b75ce30ba5d1da2d4daae9058284386696/controllers/member_controller.php#L685
• However, when Member::save does get called directly, it will pass in any field it receives. It massages certain fields, but does not clamp to fields that are defined / known to exist. So hypothetically if someone were to add POST data directly, we might try to write that. Seems unlikely that we have clients that are using the mass edit route in an automated fashion, (with possibly deprecated input) but I don't know the architecture of all possible "clients" well enough to be certain.

[annabunches]

Additional findings:

• Despite previous suppositions about Member::save, empirical testing so far has not revealed any way to set password_plaintext - injecting the appropriate form parameter on the /members/add route does not result in the value being set in the database.
• Still need to try with the API, however.

[annabunches]

Update on this: shortly after the last comment in here we determined that the field is not in use by anything, and also that it is not populated, so this became a much lower-priority issue.