Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate valkey-hashes commit #1396

Open
vudiep411 opened this issue Dec 5, 2024 · 5 comments
Open

Automate valkey-hashes commit #1396

vudiep411 opened this issue Dec 5, 2024 · 5 comments

Comments

@vudiep411
Copy link
Contributor

The problem/use-case that the feature addresses

Currently we're manually committing the hashes into valkey-hashes every new release.

Description of the feature

We could add an automated commit the new hashes step into build-release-packages. When releasing a new version the workflow will run the following steps:

  1. Build the binary files and upload them into S3 bucket to serve valkey.io website.
  2. Run additional workflow that commit the new hash into valkey-hashes repo for checksum

Prerequisite

Create a PAT that allow write access to valkey-hashes.

Additional Information

Here is the proof of concept for the automation
Code

Screenshot 2024-12-05 at 1 58 45 PM

The runner made the new commit to this repo

Let me know if it is a good idea.

@vudiep411
Copy link
Contributor Author

@roshkhatri

@roshkhatri
Copy link
Member

Yes, this is what I was discussing with you the other day.

@roshkhatri
Copy link
Member

@valkey-io/core-team PTAL, we would also create future automation after this to commit on valkey-containers and eventually also update the links for the binaries download pages for valkey-website.

@roshkhatri
Copy link
Member

Also, For this and future automations, Can we setup a bot account which will have the PAT for the repos like valkey-hashes and valkey-container.

Once the release is complete on the main repo, it will trigger the bot to make the commits on valkey-hashes and valkey containers.

Keeping workflows for the commits on other repos in the main repo does not make sense to me.

I think we should centralize these in a repository called as valkey-automation-bot in a valkey-bot-user which will house scripts for all the commits and automations for the release, triggered by the release workflow on the valkey repo.

I think this needs an issue by itself. I will create it

@vudiep411
Copy link
Contributor Author

I agree with this design. We can set a trigger workflow step in this main valkey-repo that will trigger the bot automation and it will make commits in the appropriate repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants