Immediately restart the defrag cycle if we still need to defrag #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Madelyn Olson <[email protected]>
Signed-off-by: Madelyn Olson <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1492 +/- ##
============================================
- Coverage 70.86% 70.83% -0.03%
============================================
Files 119 119
Lines 64852 64861 +9
============================================
- Hits 45958 45945 -13
- Misses 18894 18916 +22
|
|
First full run looked good, so starting a second one but also making it ready for review since I'm going to sleep. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One very subtle change of #1242, is that we now wait for the server cron to start a new defrag cycle. Whereas previously we started it immediately. All of the current tests rely on the behavior of "Active defrag runs until it is done", which was broken because now there is a short period of active defragmentation reports itself off. Running a bunch of tests while this is in a draft, but opening it incase anyone else was taking a look.
Intended to close #1454.
https://github.com/valkey-io/valkey/actions/runs/12524316525/job/34934755959 [Only failure is active-defrag related, but not related to this issue]
https://github.com/valkey-io/valkey/actions/runs/12524547410