Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel Method Issue at the PaypalReturnController #3

Open
fulopattila122 opened this issue Mar 16, 2021 · 4 comments
Open

Cancel Method Issue at the PaypalReturnController #3

fulopattila122 opened this issue Mar 16, 2021 · 4 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@fulopattila122
Copy link
Member

@fulopattila122 I have detected another issue with the cancel method, at the PaypalReturnController. Should I open another PR to discuss the issue, or should I wait?

Thank you by the way for the vanilo framework!

Originally posted by @damarev in #2 (comment)

@fulopattila122
Copy link
Member Author

@kedves could you please check this one? thx!

@fulopattila122 fulopattila122 added bug Something isn't working documentation Improvements or additions to documentation labels Mar 16, 2021
@damarev
Copy link
Contributor

damarev commented Mar 16, 2021

The problem I have detected is, the generated return url from paypal currently doesnt have the paymentId as parameter.

@fulopattila122
Copy link
Member Author

You need to pass a unique return url to PayPal that contains the payment I'd, so that you can look it up on return

@damarev
Copy link
Contributor

damarev commented Mar 16, 2021

Sorry, the return success url does have the paymentId parameter, its in the cancel url that is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants