Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug/Crash]: Editor Presence setting cannot be enabled #40

Closed
2 tasks done
amuck-gorilla opened this issue Nov 5, 2023 · 21 comments
Closed
2 tasks done

[Bug/Crash]: Editor Presence setting cannot be enabled #40

amuck-gorilla opened this issue Nov 5, 2023 · 21 comments
Assignees
Labels
bug Something isn't working

Comments

@amuck-gorilla
Copy link

What happened?

When I turn on the Editor Presence setting and click on the "Save and Restart" button, the editor closes, does not start back up, and when I start it back up manually and open Project Settings, the setting has turned itself back off.

I expected the editor to start back up with Editor Presence enabled.

I tried reinstalling the addon and got a bunch of Parse Errors. The first time I tried to enable the setting the editor did reopen, even though the setting remained off, but after that first time it went back to failing in the same way.

Version

3.2

Godot Version

v4.1.1.stable.official

GDScript

# No files open

Godot output

Godot Engine v4.1.1.stable.official (c) 2007-present Juan Linietsky, Ariel Manzur & Godot Contributors.
  modules/gltf/register_types.cpp:73 - Blend file import is enabled in the project settings, but no Blender path is configured in the editor settings. Blend files will not be imported.
--- Debug adapter server started ---
--- GDScript language server started ---
Add Autoload

# When restarted after plugin was enabled again after re-installing

Godot Engine v4.1.1.stable.official (c) 2007-present Juan Linietsky, Ariel Manzur & Godot Contributors.
  modules/gltf/register_types.cpp:73 - Blend file import is enabled in the project settings, but no Blender path is configured in the editor settings. Blend files will not be imported.
--- Debug adapter server started ---
--- GDScript language server started ---
  gdscript://-9223370559637626267.gd:4 - Parse Error: Identifier "discord_sdk" not declared in the current scope.
  gdscript://-9223370559637626267.gd:7 - Parse Error: Identifier "discord_sdk" not declared in the current scope.
  gdscript://-9223370559637626267.gd:39 - Parse Error: Identifier "discord_sdk" not declared in the current scope.
  gdscript://-9223370559637626267.gd:39 - Parse Error: Identifier "discord_sdk" not declared in the current scope.
  gdscript://-9223370559637626267.gd:39 - Parse Error: Identifier "discord_sdk" not declared in the current scope.
  gdscript://-9223370559637626267.gd:39 - Parse Error: Identifier "discord_sdk" not declared in the current scope.
  gdscript://-9223370559637626267.gd:39 - Parse Error: Identifier "discord_sdk" not declared in the current scope.
  gdscript://-9223370559637626267.gd:39 - Parse Error: Identifier "discord_sdk" not declared in the current scope.
  gdscript://-9223370559637626267.gd:39 - Parse Error: Identifier "discord_sdk" not declared in the current scope.
  gdscript://-9223370559637626267.gd:39 - Parse Error: Identifier "discord_sdk" not declared in the current scope.
  gdscript://-9223370559637626267.gd:39 - Parse Error: Identifier "discord_sdk" not declared in the current scope.
  gdscript://-9223370559637626267.gd:39 - Parse Error: Identifier "discord_sdk" not declared in the current scope.
  gdscript://-9223370559637626267.gd:39 - Parse Error: Identifier "discord_sdk" not declared in the current scope.
  gdscript://-9223370559637626267.gd:39 - Parse Error: Identifier "discord_sdk" not declared in the current scope.
  gdscript://-9223370559637626267.gd:39 - Parse Error: Identifier "discord_sdk" not declared in the current scope.
  gdscript://-9223370559637626267.gd:39 - Parse Error: Identifier "discord_sdk" not declared in the current scope.
  gdscript://-9223370559637626267.gd:39 - Parse Error: Identifier "discord_sdk" not declared in the current scope.
  gdscript://-9223370559637626267.gd:39 - Parse Error: Identifier "discord_sdk" not declared in the current scope.
  gdscript://-9223370559637626267.gd:39 - Parse Error: Identifier "discord_sdk" not declared in the current scope.
  gdscript://-9223370559637626267.gd:49 - Parse Error: Identifier "discord_sdk" not declared in the current scope.
  gdscript://-9223370559637626267.gd:52 - Parse Error: Identifier "discord_sdk" not declared in the current scope.
  gdscript://-9223370559637626267.gd:55 - Parse Error: Identifier "discord_sdk" not declared in the current scope.
  gdscript://-9223370559637626267.gd:58 - Parse Error: Identifier "discord_sdk" not declared in the current scope.
  gdscript://-9223370559637626267.gd:62 - Parse Error: Identifier "discord_sdk" not declared in the current scope.
  gdscript://-9223370559637626267.gd:64 - Parse Error: Identifier "discord_sdk" not declared in the current scope.
  gdscript://-9223370559637626267.gd:67 - Parse Error: Identifier "discord_sdk" not declared in the current scope.
  Script does not inherit from Node: res://addons/discord-sdk-gd/nodes/core_updater.gd.
  editor/editor_autoload_settings.cpp:551 - Condition "!info->node" is true. Continuing.
Add Autoload

Additional information

No response

Checks

  • I tried reinstalling the addon or tried to fix it myself with other methods.
  • I tried restarting Discord and Godot completely.
@amuck-gorilla amuck-gorilla added the bug Something isn't working label Nov 5, 2023
@amuck-gorilla
Copy link
Author

I hope you can fix this. Editor Presence seemed like a really great feature.

@vaporvee
Copy link
Owner

vaporvee commented Nov 5, 2023

Please give me the current OS you are on. Did you enable the plugin and restart and saw the popup? a restart dialog with the plugin logo should appear

@vaporvee
Copy link
Owner

vaporvee commented Nov 5, 2023

what happens is that the gdextension didn't load. but that should give you more error messages then just not declared

@amuck-gorilla
Copy link
Author

I am on Microsoft Windows 11 Home, version 10.0.22631 Build 22631

  1. I installed the plugin
  2. I enabled it
  3. I saw the popup (It had text covering the buttons to "Restart" and "Save and Restart", preventing me from clicking them, but when I closed the window Godot restarted just fine)
  4. Godot restarted
  5. I went to settings
  6. I enabled the Editor Rich Presence setting
  7. The "Save and Restart" button wouldn't work, so I closed Godot manually and reopened the project.

@vaporvee
Copy link
Owner

vaporvee commented Nov 7, 2023

huh thats really weird... could you make a project how you would set it up with the plugin and send it to me? I'll take a look myself

@amuck-gorilla
Copy link
Author

The error happened while I was trying to set the extension up for this project: amuck-gorilla/Game-Off-arena-prototype

@RemoteCodeExecution
Copy link

RemoteCodeExecution commented Nov 24, 2023

Having the same issue on Windows 10 19045.3693. Godot 4.1.3

  1. Installed the plugin (tried from the AssetStore and manual install)
  2. Enabled the plugin, got a pop up prompting me to restart or save & restart in order to fully enable this plugin
  3. Restarted then went to settings and enabled editor rich presence
  4. Save and restart button did work
  5. Godot restarted
  6. Went to settings but editor rich presence is still set to OFF
  7. Enabled it again and restarted
  8. This time Godot does not restart by itself

I tried on a brand new project and the results are the same.

If I try to enable Editor presence again after that, this error pop-up in the output tab right after I enable it :

res://addons/discord-sdk-gd/nodes/core_updater.gd:17 - Invalid get index 'scene_file_path' (on base: 'null instance').

@amuck-gorilla
Copy link
Author

Having the same issue on Windows 10 19045.3693. Godot 4.1.3

Your description seems to describe the same problem as mine.

If I try to enable Editor presence again after that, this error pop-up in the output tab right after I enable it :

res://addons/discord-sdk-gd/nodes/core_updater.gd:17 - Invalid get index 'scene_file_path' (on base: 'null instance').

I'm pretty sure I never got that error though.

@vaporvee
Copy link
Owner

will help you as soon as possible sorry

@vaporvee
Copy link
Owner

The error happened while I was trying to set the extension up for this project: amuck-gorilla/Game-Off-arena-prototype

theres no branch with my plugin

@yusdacra

This comment was marked as off-topic.

@vaporvee
Copy link
Owner

vaporvee commented Nov 28, 2023

@yusdacra

has nothing todo with this issue please make a new one

@vaporvee
Copy link
Owner

Having the same issue on Windows 10 19045.3693. Godot 4.1.3

1. Installed the plugin (tried from the AssetStore and manual install)

2. Enabled the plugin, got a pop up prompting me to restart or save & restart in order to fully enable this plugin

3. Restarted then went to settings and enabled editor rich presence

4. Save and restart button did work

5. Godot restarted

6. Went to settings but editor rich presence is still set to OFF

7. Enabled it again and restarted

8. This time Godot does not restart by itself

I tried on a brand new project and the results are the same.

If I try to enable Editor presence again after that, this error pop-up in the output tab right after I enable it :

res://addons/discord-sdk-gd/nodes/core_updater.gd:17 - Invalid get index 'scene_file_path' (on base: 'null instance').

could you then maybe send me a fresh project zipped how you wpuld setup the plugin?

@RemoteCodeExecution
Copy link

Having the same issue on Windows 10 19045.3693. Godot 4.1.3

1. Installed the plugin (tried from the AssetStore and manual install)

2. Enabled the plugin, got a pop up prompting me to restart or save & restart in order to fully enable this plugin

3. Restarted then went to settings and enabled editor rich presence

4. Save and restart button did work

5. Godot restarted

6. Went to settings but editor rich presence is still set to OFF

7. Enabled it again and restarted

8. This time Godot does not restart by itself

I tried on a brand new project and the results are the same.
If I try to enable Editor presence again after that, this error pop-up in the output tab right after I enable it :
res://addons/discord-sdk-gd/nodes/core_updater.gd:17 - Invalid get index 'scene_file_path' (on base: 'null instance').

could you then maybe send me a fresh project zipped how you wpuld setup the plugin?

Sure.

Here is a zip file containing a fresh project with your add-on installed and enabled. https://github.com/RemoteCodeExecution/Fresh_Project_Godot

The plugin indeed seem to load as I was able to add my own application to Discord following your "Quick Start" guide, and upon running the project it indeed show up on my Discord profile.

The issue seem to be only with the EditorPresence feature. No matter what I do, it just won't stay enabled upon restarting Godot, and no editor presence will show up on my Discord profile.

@vaporvee
Copy link
Owner

did you got parse errors?

@RemoteCodeExecution
Copy link

RemoteCodeExecution commented Nov 28, 2023

did you got parse errors?

This errors pop-up after installing the plugin :
install

This ones pop-up as soon as I enable the plugin :
plugin_enabled

And this errors after restarting as asked by the plugin pop-up :
plugin_after_restart

I get no error after that if I try to enable Editor Presence, but upon restarting it's disabled.

If I then try to enable it again, Godot won't restart by itself when using the save and restart option after enabling Editor Presence. Have to manually restart it and Editor Presence is still set to off.

@vaporvee
Copy link
Owner

the first 2 errors are normal thats why restarting is required but the third one i investigate when I'm home. but i will do an update soon where i will redo stuff i made in gdscript with gdextension/cpp that will hopefully run more reliable. Also i will make seperate nodes loaded in background instead of this weird single gdscript autoload.

@vaporvee
Copy link
Owner

vaporvee commented Dec 4, 2023

okay you don't need to restart godot and a crash that was undiscovered happens actually everytime on close. until the next update do not press the save and restart button, save the project and editorpresence should just work

@yunylz
Copy link

yunylz commented Dec 13, 2023

ur saying "click" restart when you cant even do that
Screenshot 2023-12-14 00 02 47

@yunylz

This comment has been minimized.

@vaporvee
Copy link
Owner

make your own issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants