Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve / optimize Material related types and logic #200

Open
vatro opened this issue Dec 18, 2022 · 0 comments
Open

Improve / optimize Material related types and logic #200

vatro opened this issue Dec 18, 2022 · 0 comments
Labels
API code quality general General issue Types
Milestone
1.0.0-next.X

Comments

@vatro
Copy link
Owner

vatro commented Dec 18, 2022

Reference this issue when improving / optimizing Material related types and logic in general.
vatro pushed a commit that referenced this issue Dec 18, 2022
types-extra Refactor MeshAssignableMaterial and `PointsAssignable…
f5dce29 
…Material` types (#200)

Make them more explicit.
vatro pushed a commit that referenced this issue Dec 18, 2022
types-extra Introduce MeshMaterialWithColor and `MeshMaterialWith…
bd41d70 
…EnvMap` (#200)

This way the type of Material can be further narrowed for common use cases:
-  `MeshMaterialWithColor`:  can be used with functions which assign / alter Material's color
-  `MeshMaterialWithEnvMap`:  can be used with functions which assign / alter Material's environment map, e.g. the `CubeCamera` component.
vatro pushed a commit that referenced this issue Dec 18, 2022
index.ts Export Material related types (#200)
c9e2161 
So that they can be imported via `import type { Foo }  from "svelthree"`.
vatro pushed a commit that referenced this issue Dec 18, 2022
Mesh & Points Make IState* interface generic, use `AssignedMate…
18fe21e 
…rial` (#200)
vatro pushed a commit that referenced this issue Dec 18, 2022
CubeCamera Use new MeshMaterialWithEnvMap type (#200)
5e26402
@vatro vatro added this to the 1.0.0-next.X milestone Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API code quality general General issue Types
Projects
None yet
Milestone
1.0.0-next.X
Development

No branches or pull requests
1 participant
@vatro