-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shadowbox not mobile responsive #55
Comments
I have been using http://chocolat.insipi.de/ lately, what do you think? |
Hi Timo, just having a look at that.... The only issues I can see are that it doesn't appear to support swipe, and that, on a phone, the arrows and buttons are extremely tiny.. i.e. they aren't scaling. Without swiping, one has to find the tiny arrows. I have done this type of thing once before when I did the lightbox for the Nevoweb store and also in custom Revindex templates I built. I used this one: https://github.com/marekdedic/imagelightbox The only downside I've found with it is that it doesn't support pinch-zooming. I didn't find any that did 100% of everything at the time and so I went with that one. It does look like it has been getting updates recently, so I need to check it again in detail. |
My problem with many lightbox scripts, incl this one, is that they do not come WCAG2-proof out of the box. For us accessibility is vital. Why not make use of the existing Bootstrap modal possibilities? |
IMO you already can implement any custom lightbox you want. I don't think having a dependency on Bootstrap is good TBH. |
That’s true. However DNN is always provided with Bootstrap... |
@b-creative Ehh. I don't think so.. are you talking about jQuery? |
Well, this will always a difficult thing to decide as it's also preference. |
True |
Just FYI, the replacement lightbox script is very old and doesn't size images to fit mobile screens. There are heaps of similar scripts that are responsive but I don't know which would best fit the module. A search for 'free responsive lightbox script' brings up heaps.
The text was updated successfully, but these errors were encountered: