Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pstree.py has broken types and pid handling #1446

Open
atcuno opened this issue Dec 18, 2024 · 0 comments
Open

pstree.py has broken types and pid handling #1446

atcuno opened this issue Dec 18, 2024 · 0 comments
Assignees

Comments

@atcuno
Copy link
Contributor

atcuno commented Dec 18, 2024

This is code is confusing as it expects a two element tuple even though the default is None:

https://github.com/volatilityfoundation/volatility3/blob/develop/volatility3/framework/plugins/windows/pstree.py#L64

I was trying to understand pid but its typing in the function parameters shows:

pid: objects.Pointer,

But then self._processes is declared as:

self._processes: Dict[int, Tuple[interfaces.objects.ObjectInterface, int]] = {}

And it definitely seems to store ints:

https://github.com/volatilityfoundation/volatility3/blob/develop/volatility3/framework/plugins/windows/pstree.py#L100

@superponible can you take a look at this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants