Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown "ContentType" in Xpath #524

Open
amesga opened this issue Dec 3, 2024 · 2 comments
Open

Unknown "ContentType" in Xpath #524

amesga opened this issue Dec 3, 2024 · 2 comments
Labels
a11y-display-techniques-onix Issue with the onix accessibility metadata display techniques

Comments

@amesga
Copy link

amesga commented Dec 3, 2024

<li><b>LET</b> <var>non_textual_content_audio</var> be the result of calling <a href="#check-for-node">check for node</a> on <var>onix</var>, <code class="xpath">/ONIXMessage/Product/DescriptiveDetail/DescriptiveDetail[ContentType = "21" or ContentType = "22"] </code>.

There are multiple instances where ContentType is referenced in the Xpath statements, but I don't believe ContentType is a valid term. Should this be PrimaryContentType or ProductContentType? Or both, similar to:

<li><b>LET</b> <var>non_textual_content_images</var> be the result of calling <a href="#check-for-node">check for node</a> on <var>onix</var>, <code class="xpath">/ONIXMessage/Product/DescriptiveDetail[PrimaryContentType = "07" or PrimaryContentType = "18" or PrimaryContentType = "19" or PrimaryContentType = "12" or PrimaryContentType = "49" or PrimaryContentType = "20" or ProductContentType = "07" or ProductContentType = "18" or ProductContentType = "19" or ProductContentType = "12" or ProductContentType = "49" or ProductContentType = "20"]</code>.</li>

@rickj
Copy link
Collaborator

rickj commented Dec 5, 2024

@gregoriopellegrino @gautierchomel @avneeshsingh just FYI, this is from one of the VitalSource team members.

@mattgarrish mattgarrish added the a11y-display-techniques-onix Issue with the onix accessibility metadata display techniques label Dec 10, 2024
@chrisONIX
Copy link

There are multiple instances where ContentType is referenced in the Xpath statements, but I don't believe ContentType is a valid term.
This is correct - ContentType does not exist on it's own in ONIX
Should this be PrimaryContentType or ProductContentType?
Yes tt should be both

clapierre added a commit that referenced this issue Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y-display-techniques-onix Issue with the onix accessibility metadata display techniques
Projects
None yet
Development

No branches or pull requests

4 participants