Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting for numbers with commas fails #50

Open
tomhundt opened this issue May 4, 2018 · 0 comments
Open

Formatting for numbers with commas fails #50

tomhundt opened this issue May 4, 2018 · 0 comments

Comments

@tomhundt
Copy link

tomhundt commented May 4, 2018

Hi, this is an awesome package, thanks so much for providing it!

Noticed in one of my files, dollar numeric fields, e.g., [...,] "$100,015.00", [...] don't render properly -- the "string" rendering stops at the comma in the middle, whereupon it changes to the same style as numeric constants and dates. Experimentation reveals that the dollar sign makes it think that's a string-format field (any letter does the same thing). IMO the whole thing should just be displayed as a string, including the embedded comma.

Here's an example
one,two,three,four
1,"$200,000",567,hello
comes out as
render_money_number

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant