Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeping in sync with testharness.js? #2

Open
foolip opened this issue Aug 1, 2019 · 5 comments
Open

Keeping in sync with testharness.js? #2

foolip opened this issue Aug 1, 2019 · 5 comments

Comments

@foolip
Copy link
Member

foolip commented Aug 1, 2019

https://github.com/web-platform-tests/editor/blob/master/wwwroot/bin/testharness.js is a copy of wpt's testharness.js, which needs to be kept in sync. Is there a way to keep this dependency fresh?

@snuggs
Copy link

snuggs commented Jan 6, 2020

@foolip perhaps a githook with a curl?
There is a git archive that does just this ! HOWEVER... disabled on github :-(

As a last resort there is git SVN. Although it feels like eating soup with a fork it does work.

Lastly I don't mind working on this as i've had to do the same for testharness.js in the past (using curl). But i'm not very familiar with this project on WPT.

Your thoughts..

@foolip
Copy link
Member Author

foolip commented Jan 16, 2020

One option would be to reference https://wpt.live/resources/testharness.js.

Another is to copy it from the wpt in a build step.

@snuggs
Copy link

snuggs commented Feb 10, 2020

@foolip 👍 for copy (& commit). FWIW Have attempted your first suggestion before and was up all night on false errors from a server being down for maintenance. Not saying this isn't a possibility with latter method. But at least possibility of earlier discovery.

Thanks!

@foolip
Copy link
Member Author

foolip commented Feb 13, 2020

@stephenmcgruer do we have uptime monitoring of wpt.live and some kind of SLA, if someone does want to depend on it being "always" up?

@stephenmcgruer
Copy link

To answer the latter first, we do not currently have an SLA for wpt.live and I don't expect us to add one. It is a best-effort system currently. That said I'm surprised to hear of the report of the server being down (I don't expect much if any downtime); @snuggs do you know when this happened?

Wrt monitoring, we have basic GCP monitoring but nothing specific setup yet. cc @LukeZielinski as a vague fyi that this might fit into the productionization effort (as part of best-practices for our GCP hosted services).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants