-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What if a block doesn't have any output? #7
Comments
{ "result": null, "error": null} Maybe? On Sun, Dec 2, 2012 at 6:56 PM, Matthew Hudson [email protected]:
Jeff Lindsay |
Probably best to return an empty object for consistency and to signal "success". It functions just like other blocks, it just happens to have no outputs. I was also considering whether the email block should have an output, maybe called "success", but I guess that's implicit in the block returning the empty object. Maybe some pipeline variants could have success/error outputs that you could pipe to other blocks. Also I'd leave the |
Wouldn't success be implied by the Status Code? Although, if we're moving Thanks, |
True, the status code should imply success. Since it's called WebPipes I don't think we should avoid using HTTP features for the sake of other transports. We can always just tack on status codes and headers to the request/response objects when using other transports, etc. |
For example, the send email block doesn't have any output. I vote we send a 2xx and an empty response body.
The text was updated successfully, but these errors were encountered: