Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(astro): do not open new tab when saving config files #11456

Conversation

RickyC0626
Copy link
Contributor

@RickyC0626 RickyC0626 commented Jul 11, 2024

Changes

Testing

To reproduce the manual test locally:

Run build with changes

pnpm run build

Run astro dev

pnpm --filter astro dev

Test the changes using the following example:

pnpm --filter @example/minimal dev --open

Expected behavior:

  • Open new tab on first run of dev command, then update the same tab on each file save
  • Saving config files shouldn't spawn new tabs

Docs

Unexpected behavior has been fixed, no additional docs needed

Copy link

changeset-bot bot commented Jul 11, 2024

🦋 Changeset detected

Latest commit: dfeae94

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 11, 2024
@RickyC0626
Copy link
Contributor Author

@florian-lefebvre

@RickyC0626 RickyC0626 marked this pull request as ready for review July 11, 2024 16:53
@florian-lefebvre florian-lefebvre self-requested a review July 11, 2024 18:25
@florian-lefebvre florian-lefebvre requested a review from bluwy July 15, 2024 16:03
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. fwiw it's not a problem in macos as it's possible to use an applescript to reuse the existing tab, but not possible (i think?) for other OSes.

@florian-lefebvre florian-lefebvre merged commit 17e048d into withastro:main Jul 16, 2024
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If the -- open flag is used, any modifications to the packagist.json file will reopen the browser at this time
3 participants