Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions: give better guidance when a Response is returned by an Action #11828

Merged
merged 8 commits into from
Aug 26, 2024

Conversation

bholmesdev
Copy link
Contributor

Changes

We give a pretty unfriendly DevalueError when an action returns non-serializable data. This is especially confusing when returning a Response or a redirect.

  • Wrap the DevalueError with a well-formatted message
  • Offer specific hints for Response and redirect objects
  • Remove redirect() from the Action context object

Testing

N/A

Docs

N/A

Copy link

changeset-bot bot commented Aug 23, 2024

🦋 Changeset detected

Latest commit: 4fd6e6a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Aug 23, 2024
@bholmesdev bholmesdev merged commit 20d47aa into main Aug 26, 2024
14 checks passed
@bholmesdev bholmesdev deleted the refactor/remove-redirect-from-types branch August 26, 2024 21:53
@astrobot-houston astrobot-houston mentioned this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants