Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve e2e setup #11850

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Improve e2e setup #11850

merged 1 commit into from
Aug 27, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Aug 27, 2024

Changes

  • Simplify playwright config setup (removed comments as they intellisense can provide better explanation on hover)
  • Reduce retries from 3 to 2, since we already run the test once, and then retry 3 times again, this makes a total of 4 runs, which I think is a bit too many, and could cause the CI to cut off after 20min and unable to show what failed for debugging
  • Update e2e to each use its own port, and enable Vite's strictPort to prevent possible sharing. (this required some import.meta.url refactoring to ensure the right ports are used)
  • Enable multiple workers locally so it runs faster
  • Fix flaky tests in actions-blog.test.js and actions-react-19.test.js by waiting for the islands to hydrate first.

Testing

CI should pass

Docs

n/a

Copy link

changeset-bot bot commented Aug 27, 2024

⚠️ No Changeset found

Latest commit: 16d16c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 27, 2024
@bluwy
Copy link
Member Author

bluwy commented Aug 27, 2024

Ran the ubuntu e2e tests on CI twice and it seems to pass now, though the test can still sometimes be flaky.

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup!

@bluwy bluwy merged commit ccce6d2 into main Aug 27, 2024
13 checks passed
@bluwy bluwy deleted the improve-e2e-setup branch August 27, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants