Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document limitations of island prop serialization #9557

Open
ascorbic opened this issue Oct 4, 2024 · 4 comments
Open

Document limitations of island prop serialization #9557

ascorbic opened this issue Oct 4, 2024 · 4 comments
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. help wanted Issues looking for someone to run with them!

Comments

@ascorbic
Copy link
Contributor

ascorbic commented Oct 4, 2024

📚 Subject area/topic

Islands

📋 Suggested page

  • guides/framework-components
  • guides/server-islands

📋 General description or bullet points (if proposing new content)

The framework components guide documents the fact that you can't pass functions to client components, but it doesn't document any of the other restrictions. It also doesn't document any of these for server islands. Values must be serializable, and the following types are supported: plain object, number, string, Array, Map, Set, RegExp, Date, BigInt, URL, Uint8Array, Uint16Array, Uint32Array, Infinity. Circular references and functions are not supported.

🖥️ Reproduction of code samples in StackBlitz

No response

@ascorbic ascorbic added the add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. label Oct 4, 2024
@sarah11918 sarah11918 added the help wanted Issues looking for someone to run with them! label Oct 6, 2024
@sarah11918
Copy link
Member

Thanks Matt! Where are our framework/island fans? Who wants to help update docs??

@branberry
Copy link
Contributor

Hey Sarah! I'm still an Astro newbie, but I'd be open to giving this a go.

@sarah11918
Copy link
Member

Hey @branberry , sounds great!

I'll just note that we are closing up shop on v4 docs at the moment, so any new content should be made in a PR to the 5.0.0-beta branch!

Also, as we have a lot of moving parts getting ready for v5, we would prefer not to have longstanding draft PRs open and sticking around, so feel free to use this space for questions/discussions and others are welcome to chime in. When you feel confident that you have a PR ready to go for review, then we'd happily accept a PR that is closer to finished rather than WIP! 🙌

@branberry
Copy link
Contributor

Gotcha! Thank you for letting me know. I'll make sure to withhold my PR until it's all ready for review 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. help wanted Issues looking for someone to run with them!
Projects
None yet
Development

No branches or pull requests

3 participants