Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the favicon schema so it doesn't accept absolute URL. Closes #2647 #2651

Closed
wants to merge 2 commits into from
Closed

Fix the favicon schema so it doesn't accept absolute URL. Closes #2647 #2651

wants to merge 2 commits into from

Conversation

SnowDingo
Copy link
Contributor

Description

スクリーンショット 2024-12-02 20 41 54

@SnowDingo
Modified the FaviconSchema so it doesn't accept any absolute URL for …
ac0244c 
…favicon, and throws an error when it is the case.
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: f9fe81c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Dec 2, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 2, 2024 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit f9fe81c
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/674d9f7d809b0800084d3b58
😎 Deploy Preview https://deploy-preview-2651--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SnowDingo SnowDingo mentioned this pull request Dec 2, 2024
Open
1 task
@SnowDingo SnowDingo closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🌟 core Changes to Starlight’s main package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

favicon prefixes href with leading slash (/) when url is absolute
1 participant
@SnowDingo