-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore popup/index.ts
instead of erroring
#1333
Comments
For reference, here is where we apply the glob patterns to detect entrypoint files: wxt/packages/wxt/src/core/utils/building/find-entrypoints.ts Lines 49 to 51 in ef24358
There is a test that already exists to cover this. It just needs updated slightly: remove the wxt/packages/wxt/src/core/utils/building/__tests__/find-entrypoints.test.ts Lines 671 to 694 in ef24358
Additionally, we should add another test case, basically a copy of the original, that expects an error for This issue just ignores |
In #276, an error message was added for when both
popup/index.html
andpopup/index.ts
exist. As I mentioned in this comment, it would be better to simply ignore thepopup/index.ts
file, especially since the docs suggest that a popup must be a.html
file.The text was updated successfully, but these errors were encountered: