-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dimension order should be set by input_dims #126
Comments
I will treat the edge case in which the output dimension order does not agree with the order specified by |
@maxrjones, i've hit a roadblock while trying to come up with a patch for this issue and would love your input if you ever made any progress on this issue in the past :) |
👋🏽@maxrjones, the gentlest of bumps on this when you get a chance :) |
What is your issue?
In most cases, the batch generator will permute the dimension order to agree with the order specified in
input_dims
. Here is an example:In at least one case, the original dimension order is retained:
We should document the intended behavior for ordering dimensions and test that the shape is consistent. I would have expected that the original dimension would be retained, in contrast to the most common behavior of the batch generator. @jhamman can you provide insight into the original intended behavior?
The text was updated successfully, but these errors were encountered: