Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAMCS Studio Crashing if YAMCS is restarted #124

Open
unlikelyzero opened this issue Jun 29, 2023 · 1 comment
Open

YAMCS Studio Crashing if YAMCS is restarted #124

unlikelyzero opened this issue Jun 29, 2023 · 1 comment

Comments

@unlikelyzero
Copy link

unlikelyzero commented Jun 29, 2023

We're actively investigating an issue with YAMCS Studio freezing up if the main YAMCS instance, itself, is restarted or crashes.

We can continue our internal investigation, but I was wondering if this is a supported usecase or a known issue before we go much further.

We originally thought it was related to #113

I think it might be at the root of this request: #112

More notes to come

@fqqb
Copy link
Member

fqqb commented Jun 30, 2023

Freeze/crash is bad. I would expect that it just disconnects the client. We refer to the WebSocket connection to determine if a client is connected. Even in the case of a hard crash of the server, that should close eventually due to heartbeat mechanism. But from your description, seems something going wrong there for sure.

About #112, auto reconnection would first require some work on the server. When there's no auth this is quite straightforward, but when there is, it requires the server to somehow keep track of authentication sessions so that they can be restored. This is especially important for the standard token flow, where user passwords are only accessed once on the first login (then exchanged for tokens). I have been making moves towards that (introduction of "Admin Area > Sessions" page), but needs more work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants