Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dir sessions in runtime not make sense #240

Open
RodrigoDornelles opened this issue Dec 15, 2021 · 1 comment
Open

Make dir sessions in runtime not make sense #240

RodrigoDornelles opened this issue Dec 15, 2021 · 1 comment
Labels

Comments

@RodrigoDornelles
Copy link

Because redis session inherits the default session class, it ends up creating the session folder, this could be removed.

I'm in doubt about the best way to remove this abstraction would be unnecessary, as it's all tied to file sessions.

https://github.com/yiisoft/yii2/blob/36ef75338536e855432ae7bd4a24d455fde63f90/framework/web/Session.php#L379

public function setSavePath($value)
  {
      $path = Yii::getAlias($value);
      if (is_dir($path)) {
          session_save_path($path);
      } else {
          throw new InvalidArgumentException("Session save path is not a valid directory: $value");
      }
  }
@samdark samdark added the type:bug Bug label Dec 15, 2021
@samdark
Copy link
Member

samdark commented Dec 15, 2021

Yes, that could be considered a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants