Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect behavior in internal_doc.changeID.versionVector size when attaching a new document #925

Open
raararaara opened this issue Nov 5, 2024 · 0 comments
Labels
bug 🐞 Something isn't working

Comments

@raararaara
Copy link
Contributor

What happened:
When attaching a new document, it seems that the size of internal_doc.changeID.versionVector does not decrease as expected and only appends new entries. In the logic that clears the Lamport of a detached client, there appears to be an issue with using the minimum version vector to accurately relay active client information. This causes an incorrect state during the detaching and deactivating process.

What you expected to happen:
The internal_doc.changeID.versionVector should properly reflect the current state, with the size decreasing when necessary, ensuring that active client information is accurately maintained during deactivation and detachment.

How to reproduce it (as minimally and precisely as possible):

  1. Activate a client and attach the document.
  2. Observe the size of doc.changeID.versionVector after the attachment.
  3. Detach the client and attach additional client and observe the size of doc.changeID.versionVector after the attachment.

Anything else we need to know?:

Environment:

  • Operating system:
  • Browser and version:
  • Yorkie version (use yorkie version): 0.5.4
  • Yorkie JS SDK version: 0.5.4
@raararaara raararaara added the bug 🐞 Something isn't working label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant