Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links are not actual links in the sidebar (prevents from opening in a new tab) #532

Open
zaynetro opened this issue May 30, 2017 · 2 comments
Open

Links are not actual links in the sidebar (prevents from opening in a new tab) #532

zaynetro opened this issue May 30, 2017 · 2 comments

Comments

@zaynetro
Copy link

The links in the sidebar are <span> elements which prevents users from opening them in a new tab.

Ex:

yourturn/client/lib/yourturn/src/sidebar/sidebar.jsx

Line 117 in 2abef4e

<span className='sidebar-item-link'>

Just by changing them to <a> element will resolve a lot of frustration users have.

Do you think this needs fixing? I can do a pull request with the change.
@hjacobs
Copy link
Contributor

hjacobs commented May 30, 2017

@neremic is this something you can answer (or your team)?

@zaynetro
Copy link
Author

Any progress on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hjacobs @zaynetro