-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Failing JS Unit Tests & File Import Error #1296
base: main
Are you sure you want to change the base?
Conversation
CI should be changed to run the tests, not only to ensure that this is fixed but to not regress again. For follow ups better use a different branch name, |
CI issue is different; this PR resolves the issue that was stopping the execution of tests locally (atleast) |
So you cant run the test locally? |
Can you try |
Yeah its working fine. Isn't it utilizing Java tests? Why can't we run ava directly? |
That error shows |
The fix is just for the import statement; not for the whole unit tests file. Second, I can see the gradle job is running java tests, and not ava ones. Should I focus on Java unit tests or on JS ones? |
For me the java tests are the most important, but the js ones would be good to fix too.. |
It is complete now |
|
Is it possible to execute only the failing unit test and not zapRunTests each time? |
Before d7019fb module was throwing error in browser resulting in failed initialization of HUD. Now, if you run UPDATE |
New Issues
Fixed Issues
|
The PR is ready for review; the building failing doesn't make sense to me as ZAP HUD is working fine locally. |
Signed-off-by: Najam Ul Saqib <[email protected]>
Signed-off-by: Najam Ul Saqib <[email protected]>
Signed-off-by: Najam Ul Saqib <[email protected]>
Signed-off-by: Najam Ul Saqib <[email protected]>
Signed-off-by: Najam Ul Saqib <[email protected]>
Signed-off-by: Najam Ul Saqib <[email protected]>
Signed-off-by: Najam Ul Saqib <[email protected]>
Signed-off-by: Najam Ul Saqib <[email protected]>
Signed-off-by: Najam Ul Saqib <[email protected]>
This reverts commit 3f37003. Signed-off-by: Najam Ul Saqib <[email protected]>
This reverts commit 422853d. Signed-off-by: Najam Ul Saqib <[email protected]>
Signed-off-by: Najam Ul Saqib <[email protected]>
The code had two failing JS unit tests which has been fixed
also fixes #1103