Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weak warning from pycharm #129

Open
vrst37 opened this issue Aug 15, 2018 · 3 comments
Open

Weak warning from pycharm #129

vrst37 opened this issue Aug 15, 2018 · 3 comments

Comments

@vrst37
Copy link

vrst37 commented Aug 15, 2018

Hello,
When I write the following code

from pyre import Pyre

I get a weak warning from pycharm saying "Pyre is not declared in all"

@sphaero
Copy link
Contributor

sphaero commented Aug 21, 2018

I'm not familiar with pycharm but if you know of a fix please make PR

@vrst37
Copy link
Author

vrst37 commented Sep 5, 2018

Hi, All we need to do it update the init file.
from
__all__ = ['pyre', 'zbeacon', 'zhelper']
to
__all__ = ['pyre', 'Pyre', 'PyreEvent', 'zbeacon', 'zhelper']

Should I make a pull request for it? Or do you think such a small change can be added to the next release

@sphaero
Copy link
Contributor

sphaero commented Sep 6, 2018

Yes please send a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants