Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ASM code on multiple platforms #8

Open
zonyitoo opened this issue Oct 4, 2015 · 5 comments
Open

Test ASM code on multiple platforms #8

zonyitoo opened this issue Oct 4, 2015 · 5 comments

Comments

@zonyitoo
Copy link
Owner

zonyitoo commented Oct 4, 2015

Right now I can only test it on Linux x86_64 and OS X x86_64, not sure the ASM could run in other platforms.

This was referenced Oct 4, 2015
@polyfractal
Copy link
Contributor

Any chance of adding NetBSD support? I looked around, but frankly I have no idea what asm needs to be changed/modified to make it work on NetBSD. But I'd be happy to compile and run tests, or if you can point me towards a resource to learn more, I could send a PR (maybe heh)

@zonyitoo
Copy link
Owner Author

Can it be compiled on NetBSD?

@polyfractal
Copy link
Contributor

Not at the moment, no. There is no conditional compilation target for target_record_sp_limit() and target_get_sp_limit() (just freebsd and dragonfly).

I considered trying out one of the existing versions, but since the asm is different for freebsd and dragonfly...i'm not really confident netbsd would be the same? But honestly I don't really know what this code is doing anyway :(

I suppose I can try both and see if the tests pass?

@zonyitoo
Copy link
Owner Author

Yes, please. As I don't know what's the differences between NetBSD and FreeBSD, DragonFly in those functions.

@loongs-zhang
Copy link
Contributor

Please assign it to me, see https://github.com/dragon-zhang/context-rs/tree/dev_add_ci , I think it's almost perfect @zonyitoo

@zonyitoo zonyitoo assigned zonyitoo and loongs-zhang and unassigned zonyitoo Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants