Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Jekyll-specific directives from the markdown output #12

Open
rht opened this issue Dec 4, 2019 · 3 comments
Open

Remove Jekyll-specific directives from the markdown output #12

rht opened this issue Dec 4, 2019 · 3 comments

Comments

@rht
Copy link
Contributor

rht commented Dec 4, 2019

From #2 (comment) :

% include is emitted into the markdown files which isn't Markdown -- I think we should avoid doing so in the official tool, since it presumes you're using something like Jekyll or a similar markdown renderer which is a superset of markdown.

@timabbott
Copy link
Member

We should just make this an option controlled by the config file for whether the user wants Jekyll output, and document how that works.

@showell
Copy link
Contributor

showell commented Dec 18, 2019

I am hoping to get to this after some substantial code cleanup that is happening in #19. That PR fixes the issue of include, but we also have complications related to "title". For example, if you use Jekyll, but don't have a layout yet (maybe just cause you haven't gotten that far yet), the title doesn't show up now.

@showell
Copy link
Contributor

showell commented Dec 20, 2019

Sort of repeating my last comment, but we don't want to take any action on this until #19 gets merged.

In #19 I've made some structural changes that should make it a lot easier to support multiple targets. In particular, it isolates a lot of the Jekyll code in a pretty nice way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants