-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
404 on certain pages even when html view exists #51
Labels
bug
Something isn't working
Comments
It's been pointed out to me that the relevant logic lives in Lines 62 to 64 in bcd29a1
|
refeed
added a commit
to refeed/zulip-archive
that referenced
this issue
Jul 6, 2022
Use similar implementation of how zulip sanitizes its stream name and URL into a safe URL. The only difference is the function now append a non-dot char as the prefix so that it is safe to use as the filename especially for jekyll usecase where it ignores file that has dot prefix in its filename. Closes zulip#35 Closes zulip#51
I think this can be closed as we don't use jekyll anymore. |
@rht perhaps you could close this issue if you agree? Thanks! |
Though it's because of the URL encoding, not specifically Jekyll. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ex. https://juliacommunity.github.io/zulip-archive/stream/274208-helpdesk-(published)/topic/.60eachline(.3A.3AIOBuffer).60.20for.20other.20delimiters.html (source at https://github.com/JuliaCommunity/zulip-archive/blob/master/274208-helpdesk-(published)/topic/.60eachline(.3A.3AIOBuffer).60.20for.20other.20delimiters.html)
I speculate this has something to do with the leading
.
(generated in this case by the post-URLencoding % -> . replacement). Does Jekyll have some special logic for this that is tripping things up?The text was updated successfully, but these errors were encountered: