Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightbox: Add "share" button in bottom app bar #43

Open
chrisbobbe opened this issue Mar 31, 2023 · 2 comments · May be fixed by #1145
Open

lightbox: Add "share" button in bottom app bar #43

chrisbobbe opened this issue Mar 31, 2023 · 2 comments · May be fixed by #1145
Labels
a-lightbox The lightbox / image-viewer screen beta feedback Things beta users have specifically asked for
Milestone
M6: Post-launch

Comments

@chrisbobbe
Copy link
Collaborator

The share_plus plugin has an API for sharing a file: https://pub.dev/documentation/share_plus/latest/share_plus/Share/shareXFiles.html

We should try it out, for a button to share the image.

As with #42, I didn't include this in the prototype because I think it'll involve an API request; see there for details.
@gnprice gnprice added the m-beta label May 26, 2023
@gnprice gnprice added this to the Beta milestone May 27, 2023
@gnprice gnprice added a-lightbox The lightbox / image-viewer screen and removed m-beta labels May 27, 2023
@gnprice gnprice modified the milestones: Beta, Launch Sep 22, 2023
@gyoussef55
Copy link

I would like to work on it

@gyoussef55 gyoussef55 mentioned this issue Feb 25, 2024
Closed
@gnprice gnprice modified the milestones: Launch, Post-launch Jul 31, 2024
shivanshsharma13 added a commit to shivanshsharma13/zulip-flutter that referenced this issue Dec 12, 2024
@shivanshsharma13
lightbox: Add "share" button in bottom app bar
5e25382 
Add a share button to the lightbox that allows users to share image URLs.
The button appears in the bottom app bar with a share icon and tooltip.
Test coverage includes verifying the share button's UI elements (icon and
tooltip)

Fixes: zulip#43
@shivanshsharma13 shivanshsharma13 linked a pull request Dec 12, 2024 that will close this issue
Open
shivanshsharma13 added a commit to shivanshsharma13/zulip-flutter that referenced this issue Dec 12, 2024
@shivanshsharma13
lightbox: Add "share" button in bottom app bar
7dcb6d1 
Add a share button to the lightbox that allows users to share image URLs.
The button appears in the bottom app bar with a share icon and tooltip.
Test coverage includes verifying the share button's UI elements (icon and
tooltip)

Fixes: zulip#43
shivanshsharma13 added a commit to shivanshsharma13/zulip-flutter that referenced this issue Dec 12, 2024
@shivanshsharma13
lightbox: Add "share" button in bottom app bar
d6bf4c8 
Add a share button to the lightbox that allows users to share image
URLs. The button appears in the bottom app bar with a share icon
and tooltip. Test coverage includes verifying the share button's UI
elements (icon and tooltip).

Fixes: zulip#43
shivanshsharma13 added a commit to shivanshsharma13/zulip-flutter that referenced this issue Dec 13, 2024
@shivanshsharma13
lightbox: Add "share" button in bottom app bar
79ad681 
Add a share button to the lightbox that allows users to share image
URLs. The button appears in the bottom app bar with a share icon
and tooltip. Test coverage includes verifying the share button's UI
elements (icon and tooltip).

Fixes: zulip#43
shivanshsharma13 added a commit to shivanshsharma13/zulip-flutter that referenced this issue Dec 13, 2024
@shivanshsharma13
lightbox: Add "share" button in bottom app bar
b1ac761 
Add a share button to the lightbox that allows users to share image
URLs. The button appears in the bottom app bar with a share icon
and tooltip. Test coverage includes verifying the share button's UI
elements (icon and tooltip).

Fixes: zulip#43
shivanshsharma13 added a commit to shivanshsharma13/zulip-flutter that referenced this issue Dec 13, 2024
@shivanshsharma13
lightbox: Add "share" button in bottom app bar
9ac3d16 
Add a share button to the lightbox that allows users to share image
URLs. The button appears in the bottom app bar with a share icon
and tooltip. Test coverage includes verifying the share button's UI
elements (icon and tooltip).

Fixes: zulip#43
shivanshsharma13 added a commit to shivanshsharma13/zulip-flutter that referenced this issue Dec 13, 2024
@shivanshsharma13
lightbox: Add "share" button in bottom app bar
40cb0ea 
Add a share button to the lightbox that allows users to share image
URLs. The button appears in the bottom app bar with a share icon
and tooltip. Test coverage includes verifying the share button's UI
elements (icon and tooltip).

Fixes: zulip#43
shivanshsharma13 added a commit to shivanshsharma13/zulip-flutter that referenced this issue Dec 13, 2024
@shivanshsharma13
lightbox: Add "share" button in bottom app bar
d5c283a 
Add a share button to the lightbox that allows users to share image
URLs. The button appears in the bottom app bar with a share icon
and tooltip. Test coverage includes verifying the share button's UI
elements (icon and tooltip).

Fixes: zulip#43
shivanshsharma13 added a commit to shivanshsharma13/zulip-flutter that referenced this issue Dec 13, 2024
@shivanshsharma13
lightbox: Add "share" button in bottom app bar
a99f96c 
Add a share button to the lightbox that allows users to share image
URLs. The button appears in the bottom app bar with a share icon
and tooltip. Test coverage includes verifying the share button's UI
elements (icon and tooltip).

Fixes: zulip#43
shivanshsharma13 added a commit to shivanshsharma13/zulip-flutter that referenced this issue Dec 13, 2024
@shivanshsharma13
lightbox: Add "share" button in bottom app bar
a8397e9 
Add a share button to the lightbox that allows users to share image
URLs. The button appears in the bottom app bar with a share icon
and tooltip. Test coverage includes verifying the share button's UI
elements (icon and tooltip).

Fixes: zulip#43
@chrisbobbe
Copy link
Collaborator Author

We got a request for this in beta feedback, emphasizing that the legacy app's "share" button in the lightbox is pretty unhelpful because it shares a string of text instead of the image file itself.

From the issue description, it seems like there's a straightforward way to share the file itself; we should do that.

@chrisbobbe chrisbobbe added the beta feedback Things beta users have specifically asked for label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-lightbox The lightbox / image-viewer screen beta feedback Things beta users have specifically asked for
Projects
Flutter app
Status: No status
Milestone
M6: Post-launch
3 participants
@gnprice @chrisbobbe @gyoussef55